[ 
https://issues.apache.org/jira/browse/SOLR-14963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222922#comment-17222922
 ] 

David Smiley commented on SOLR-14963:
-------------------------------------

I don't really have a strong opinion on this. [~arafalov] reported the problem 
on the list.  The documentation is inconsistent with the limit.  It sounds more 
straight-forward _to me_ for the limit to be as documented, thus applied to all 
parents.  This could still theoretically mean unlimited number of docs might 
get returned if there are tons of ancestry depth... but in practice that seems 
highly unlikely.   Or we just change the docs and call it done ;-)

I also tend to find this limit a really annoying gotcha that will leave you 
puzzled.  I would _prefer_ that we default to no limit, and then give people 
controls to rein this in if it's found to be a problem.  WDYT guys?

> Child "rows" param should apply per level
> -----------------------------------------
>
>                 Key: SOLR-14963
>                 URL: https://issues.apache.org/jira/browse/SOLR-14963
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Major
>
> The {{[child rows=10]}} doc transformer "rows" param _should_ apply per 
> parent, and it's documented this way: "The maximum number of child documents 
> to be returned per parent document.".  However, it is instead implemented as 
> an overall limit as the child documents are processed in a depth-first order 
> way.  The implementation ought to change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to