cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r517889175
##########
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##########
@@ -146,93 +149,114 @@ public LTRQParser(String qstr, SolrParams localParams,
SolrParams params,
@Override
public Query parse() throws SyntaxError {
Review comment:
7/n minor comments:
* technically not just `modelNames[0]` but all the model names could be
`isEmpty` checked
* `threadManager.setExecutor` (already mentioned in 6/n) need not be inside
the loop, likewise `extractFeatures` and `fvStoreName` and
`extractEFIParams(localParams)` could move out.
##########
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.ltr.interleaving;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.LinkedHashSet;
+import java.util.Random;
+import java.util.Set;
+
+import org.apache.lucene.search.ScoreDoc;
+
+public class TeamDraftInterleaving implements Interleaving{
Review comment:
8/n suggestions:
* class level javadocs re: the interleaving algorithm
* comments or javadocs re: any assumptions e.g.
* must rerankedA.length and rerankedB.length match?
* can rerankedA and rerankedB contain the same docs?
* can rerankedA contain the same doc more than once?
* can rerankedB contain the same doc more than once?
* consider guarding against array-index-out-of-bounds exceptions (even if
they shouldn't happen if all assumptions are met)
```
indexA = updateIndex(interleavedResults,indexA,rerankedA);
if (indexA < rerankedA.length) {
interleavedResults.add(rerankedA[indexA]);
teamA.add(rerankedA[indexA].doc);
indexA++;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
