alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518653490
##########
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##########
@@ -146,93 +149,114 @@ public LTRQParser(String qstr, SolrParams localParams,
SolrParams params,
@Override
public Query parse() throws SyntaxError {
Review comment:
as you will see in my next commit, I added the empty check in the loop
and a couple of tests for it, I leave this open, feel free to resolve this once
you take a look.
If we don't check for empty, we will get an exception anyway saying:
"cannot find model"
It's up to us if we want to help more the user with the empty message.
I think is fine, telling explicitly in an exception the model is empty could
save time for developers/integrators not understanding why a model cannot be
found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
