zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524962771
##########
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##########
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
-public class NativeUnixDirectory extends FSDirectory {
Review comment:
Thanks @dweiss and @uschindler for the reviews! The reason I originally
opened another independent PR to make native build, and replaced the
`NativeUnixDirectory` code in place here with the new flag was that, when I
played with the luceneutil tool a bit, I noticed it took two complete
lucene-solr check outs and run them side-by-side for performance testing. Plus
there's more code in native code than just open direct setting. So I thought it
might work better here if these two changes happened independently.
Will push another commit to remove `WindowsDirectory` in a day, as it's
getting too late for me now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
