uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729050496
Another thing to keep in mind: The old/new direct i/o dircetory has one problem: It uses ByteBuffer.allocateDirect on every clone. As the garbage collector needs to cleanup those direct buffers, we may run out of resources, if the clones are kept open for longer time and move to GC's old gen. For merging it is unlikely that this happens, because the indexinput/outputs are closed quite fast and the buffers in off-heap memory are small (not like MMAP). In the worst case, we may need to unmap those direct buffers sing the usual unsafe algorithms, or invent a pool of buffers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
