zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-740306114
> Hmm, `gradlew precommit` is angry: > > ``` > > Task :lucene:misc:compileJava > /l/directio/lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java:206: warning: ExtendedOpenOption is internal proprietary API and may be removed in a future release > com.sun.nio.file.ExtendedOpenOption.DIRECT); > ^ > /l/directio/lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java:325: warning: ExtendedOpenOption is internal proprietary API and may be removed in a future release > channel = FileChannel.open(path, StandardOpenOption.READ, com.sun.nio.file.ExtendedOpenOption.DIRECT); > ^ > error: warnings found and -Werror specified > > > Task :lucene:sandbox:ecjLintMain > > Task :lucene:demo:ecjLintMain > > Task :lucene:codecs:ecjLintMain > > > Task :lucene:misc:compileJava FAILED > 1 error > 2 warnings > ``` > > Maybe we need to add something like `@SuppressWarnings("sunapi")` annotation? Hmm this is strange. These warnings should have been suppressed by `@SuppressForbidden` at the constructors already. Both my local and the github PR gradle precommit check passed as well (https://github.com/apache/lucene-solr/pull/2052/checks?check_run_id=1496707362). Is this error showing up in some CI environment / job execution that I can take a further look at? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org