ShangwenWang commented on pull request #354: URL: https://github.com/apache/lucene-solr/pull/354#issuecomment-772175261
There is already a List variable named _shardNames_ and the method's function is to add content to this list. So how about naming these methods **addNames**? Is it more suitable? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
