gerlowskija edited a comment on pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#issuecomment-773515236
Hey, thanks for offering @noblepaul . I do have one thing I was puzzling over: How is SolrJ's `getV2Request`/`V2RequestSupport` feature intended to work for annotation-based v2 APIs? It looks like `V1ToV2ApiMapper` is really dependent on `CollectionApiMapping.Meta`, which the annotation-based APIs can't be found in obviously. There are some annotation-based v2 APIs whose SolrJ request classes implement V2RequestSupport (e.g. CollectionAdminRequest.ClusterProp), so there should be logic somewhere to handle that I imagine? Unless getV2Request will blow up now if called on certain CollectionAdminRequest objects? More broadly I wonder whether there's any value in getV2Request going forward. It never really "took off" to cover APIs other than CollectionAdmin, and there might be better ways to let SolrJ users dip their toes into the v2 waters (e.g. dedicated request classes that better align with the v2 paths/concepts? idk). ---- If we don't have an approach for V2RequestSupport + annotation-based APIs worked out, and there's not strong feeling about carrying V2RequestSupport forward, I'd lean towards making this PR a master-only change, and deprecating getV2Request in 8.9 so it can be removed by this PR on master. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
