iverase edited a comment on pull request #2310: URL: https://github.com/apache/lucene-solr/pull/2310#issuecomment-777438974
I have a look and I have two thoughts: 1) I wonder if we should not version PFUtil classes, instead move then to a package under Util and change the visibility of the methods. Those classes seems more like a utility to me. ~~2) Under the codecs module, there are plenty of specialise posting readers, they all have hardcodes the posting format version. I wonder if we can expose through the posting format the creation of `PostingsReaderBase`? From the SegmentReadState we should be able to get the current codec.~~ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
