[
https://issues.apache.org/jira/browse/LUCENE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287999#comment-17287999
]
Robert Muir commented on LUCENE-9796:
-------------------------------------
There are quite a few abusers in tests, grouping, etc here, so the issue isn't
particularly easy.
But in order to properly support compression for the SortedDocValues, I think
we should fix it, so that there aren't traps in the API. Even if we have to
deprecate stuff and do it iteratively.
> fix SortedDocValues to no longer extend BinaryDocValues
> -------------------------------------------------------
>
> Key: LUCENE-9796
> URL: https://issues.apache.org/jira/browse/LUCENE-9796
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Priority: Major
>
> SortedDocValues give ordinals and a way to derefence ordinal as a byte[]
> But currently they *extend* BinaryDocValues, which allows directly calling
> {{binaryValue()}}.
> This allows them to act as a "slow" BinaryDocValues, but it is a performance
> trap, especially now that terms bytes may be block-compressed (LUCENE-9663).
> I think this should be detangled to prevent performance traps like
> LUCENE-9795: SortedDocValues shouldn't have the trappy inherited
> {{binaryValue()}} method that implicitly derefs the ord for the doc, then the
> term bytes for the ord.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
