mayya-sharipova commented on pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#issuecomment-793004798
@jpountz Hi Adrien. Thanks for your review of the PR: https://github.com/apache/lucene-solr/pull/2186. I will go through your review and address your comments. I wanted to ask two assumptions I have, and check if we are ok with them: 1) A first doc with a field introduces FieldInfo for this field for the whole index, even if eventually this doc doesn't get indexed (e.g. if this doc has a too big stored field, the whole doc will be rolled back and deleted). 2) Doc values updates (`IndexWriter#updateDocValues`) are only applicable for fields that are indexed with doc values only. This was not the case before, and for example we could update doc values for a field that was indexed with postings. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
