[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339821#comment-17339821
]
Jack Conradson commented on LUCENE-9843:
----------------------------------------
I have added a new patch ([^LUCENE-9843.patch]) that incorporates the mod.patch
and removes the additional dead code from getBinary in
Lucene90DocValuesProducer. I ran coverage and it looks like all the binary code
remaining is used by tests. I checked for additional bytes written for
compressed binary fields that may have still been there, but didn't find any
(though, it's definitely possible I missed something here).
> Remove compression option on doc values
> ---------------------------------------
>
> Key: LUCENE-9843
> URL: https://issues.apache.org/jira/browse/LUCENE-9843
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Blocker
> Attachments: LUCENE-9843.patch, LUCENE-9843.patch, LUCENE-9843.patch,
> LUCENE-9843.patch, mods.patch
>
>
> Options on file formats add complexity and put a big tax on
> backward-compatibility testing. I'm the one who introduced it LUCENE-9378 but
> I would now like to think about what we can do to remove this option.
> For the record, compression was initially introduced because some binary
> fields have so much redundancy that it's wasteful not to compress them at
> all. But unfortunately, this slowed down some search workloads and we decided
> to introduce this option as a way to let users choose the trade-off they want.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
