gsmiller opened a new pull request #143: URL: https://github.com/apache/lucene/pull/143
# Description This change allows users to sub-class `DrillSideways` and override the logic for creating a "drill down" `FacetsCollector`/`FacetsCollectorManager`. This is useful if the user doesn't want to collect for drill downs (e.g., they can provide `null`), or if they're already collecting for drill downs in a custom `Collector`/`CollectorManager` that's already being provided to `search`. In the latter case, they may want to override these methods to return `null` so they don't wastefully collect for drill downs twice (once in their customer collector and again internally to `DrillSideways`). # Solution `DrillSidewaysQuery`/`DrillSidewaysScorer` already support a `null` drill down `FacetsCollector` so this is as simple as modifying `DrillSideways` itself. I added `protected` methods for creation of the drill down collectors, allowing sub-classes to override. # Tests Added new tests to test a sub-classed `DrillSideways` that provides `null` collectors. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
