apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r739865494
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##########
@@ -182,6 +313,10 @@ public void setMaxLength(int maxLength) {
this.maxLength = maxLength;
}
+ public void setFlags(Set<HighlightFlag> flags) {
Review comment:
Yes. I was working in direction of creating the builder only and later
modifying the tests after the setters are removed. I will now do both the
things: remove setters making UH immutable and modify unit tests to use the
builder instead of the earlier setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
