[
https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515594#comment-17515594
]
Yuting Gan edited comment on LUCENE-10488 at 3/31/22 9:18 PM:
--------------------------------------------------------------
Hi [~gsmiller] ,
I have brought the optimization changes of getTopDims from
{{SortedSetDocValuesFacetCounts to }}{{ConcurrentSortedSetDocValuesFacetCounts
since these two subclasses are very similar, please see #777.}} I also created
a new PR #779 for IntTaxonomyFacets, which is extended by
\{{FastTaxonomyFacetCounts and }}\{{TaxonomyFacetSumIntAssociations. }}
The optimization logic is very similar to what I did in
{{{}SortedSetDocValuesFacetCounts.{}}}I will really appreciate any feedback
from you or anyone who have time to review my PRs and will spend time on
optimizing getTopDims in \{{TaxonomyFacetSumFloatAssociations after reviewing
feedback from #777 and #779. }}
Thanks,
Yuting
was (Author: yutinggan):
Hi [~gsmiller] ,
I have brought the optimization changes of getTopDims from
{{SortedSetDocValuesFacetCounts to }}{{ConcurrentSortedSetDocValuesFacetCounts
since these two subclasses are very similar, please see
[#777|[https://github.com/apache/lucene/pull/777].]}} I also created a new
PR[#779 |[https://github.com/apache/lucene/pull/779]] for IntTaxonomyFacets,
which is extended by {{FastTaxonomyFacetCounts and
}}{{TaxonomyFacetSumIntAssociations. }}
The optimization logic is very similar to what I did in
{{{}SortedSetDocValuesFacetCounts.{}}}I will really appreciate any feedback
from you or anyone who have time to review my PRs and will spend time on
optimizing getTopDims in {{TaxonomyFacetSumFloatAssociations after reviewing
feedback from #777 and #779. }}
Thanks,
Yuting
> Optimize Facets#getTopDims across Facets implementations
> --------------------------------------------------------
>
> Key: LUCENE-10488
> URL: https://issues.apache.org/jira/browse/LUCENE-10488
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> LUCENE-10325 added a new {{getTopDims}} API, allowing users to specify the
> number of "top" dimensions they want. The default implementation just
> delegates to {{getAllDims}} and returns the number of top dims requested, but
> some Facets sub-classes can do this more optimally. LUCENE-10325 demonstrated
> this in {{SortedSetDocValueFacetCounts}}, but we can take it further. There's
> at least some opportunity to do better in:
> * {{ConcurrentSortedSetDocValuesFacetCounts}}
> * {{FastTaxonomyFacetCounts}}
> * {{TaxonomyFacetSumFloatAssociations}}
> * {{TaxonomyFacetSumIntAssociations}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
