[ https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517977#comment-17517977 ]
ASF subversion and git services commented on LUCENE-10002: ---------------------------------------------------------- Commit ccd21fa5d9df7f2a30cd81784f49b3f08116c300 in lucene's branch refs/heads/branch_9x from Luca Cavanna [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=ccd21fa5d9d ] LUCENE-10002: replace more usages of search(Query, Collector) in tests (#787) This commit replaces more usages of search(Query, Collector) with calling the corresponding search(Query, CollectorManager) instead. This round focuses on tests that implement custom collector, that need a corresponding collector manager. > Remove IndexSearcher#search(Query,Collector) in favor of > IndexSearcher#search(Query,CollectorManager) > ----------------------------------------------------------------------------------------------------- > > Key: LUCENE-10002 > URL: https://issues.apache.org/jira/browse/LUCENE-10002 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Priority: Minor > Time Spent: 17h > Remaining Estimate: 0h > > It's a bit trappy that you can create an IndexSearcher with an executor, but > that it would always search on the caller thread when calling > {{IndexSearcher#search(Query,Collector)}}. > Let's remove {{IndexSearcher#search(Query,Collector)}}, point our users to > {{IndexSearcher#search(Query,CollectorManager)}} instead, and change factory > methods of our main collectors (e.g. {{TopScoreDocCollector#create}}) to > return a {{CollectorManager}} instead of a {{Collector}}? -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org