vigyasharma commented on PR #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1106016790
The build failure is on `TestTaxonomyFacetAssociations.testFloatAssociationRandom`, and I'm unable to repro it without the randomization seed. The failure (with randomization seed) is because of a mismatch in (SUM) aggregated multi-valued, `float_random` facet field. We accept an [error delta](https://github.com/apache/lucene/blob/main/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java#L445) of 1 in this aggregation, but for the failing random seed, the delta is 1.3. For the failing random seed, the test also fails on the `main` branch. I'm not sure if this is related to the PR's changes (I don't see any related APIs being invoked by the test). My hunch is that it is some floating point approximation error. @gsmiller, i see you worked on it recently, what are your thoughts? Would it make sense increase the `delta` in assert to 1.5? -- **Failing Test** ```ruby ./gradlew test --tests TestTaxonomyFacetAssociations.testFloatAssociationRandom \ -Dtests.seed=4DFBA8209AC82EB2 -Dtests.slow=true -Dtests.locale=fr-VU \ -Dtests.timezone=Europe/Athens -Dtests.asserts=true -Dtests.file.encoding=UTF-8 ``` **Failure:** ```ruby org.apache.lucene.facet.taxonomy.TestTaxonomyFacetAssociations > testFloatAssociationRandom FAILED java.lang.AssertionError: expected:<2409060.8> but was:<2409059.5> at __randomizedtesting.SeedInfo.seed([4DFBA8209AC82EB2:1EC25C9148A9BF04]:0) at junit@4.13.1/org.junit.Assert.fail(Assert.java:89) at junit@4.13.1/org.junit.Assert.failNotEquals(Assert.java:835) at junit@4.13.1/org.junit.Assert.assertEquals(Assert.java:577) at junit@4.13.1/org.junit.Assert.assertEquals(Assert.java:701) at org.apache.lucene.facet.taxonomy.TestTaxonomyFacetAssociations.validateFloats(TestTaxonomyFacetAssociations.java:445) at org.apache.lucene.facet.taxonomy.TestTaxonomyFacetAssociations.testFloatAssociationRandom(TestTaxonomyFacetAssociations.java:256) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ... ``` **Passing Test:** ```ruby ./gradlew test --tests TestTaxonomyFacetAssociations.testFloatAssociationRandom \ -Dtests.slow=true -Dtests.locale=fr-VU -Dtests.timezone=Europe/Athens \ -Dtests.asserts=true -Dtests.file.encoding=UTF-8 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
