[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538981#comment-17538981
]
Deepika Sharma edited comment on LUCENE-10544 at 5/18/22 5:36 PM:
------------------------------------------------------------------
Thanks [~jpountz] for sharing this approach. I also feel this approach seems to
me more generic in terms of handling all types of query.
So what I currently understand is to have basically have some sort of a wrapper
class around a {{BulkScorer}} which does the timeout checks inside the
{{score}} method? Is this method similar to what is being done for all those
{{*Enum}} classes, where we have a wrapper which takes an instance and does
timeout checks and then calls the wrapper object's methods?
was (Author: JIRAUSER288832):
Thanks [~jpountz] for sharing this approach. I also feel this approach seems to
me more generic in terms of handling all type of query. So what I currently
understand is to have basically have some sort of a wrapper class around a
{{BulkScorer}} which does the timeout checks inside the {{score}} method? Is
this method somewhat similar to what is being done for all those {{*Enum}}
classes, where you have a wrapper which takes an instance, does something extra
(timeout checks in this case) and then calls the wrapper object's methods?
> Should ExitableTermsEnum wrap postings and impacts?
> ---------------------------------------------------
>
> Key: LUCENE-10544
> URL: https://issues.apache.org/jira/browse/LUCENE-10544
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Greg Miller
> Priority: Major
>
> While looking into options for LUCENE-10151, I noticed that
> {{ExitableDirectoryReader}} doesn't actually do any timeout checking once you
> start iterating postings/impacts. It *does* create a {{ExitableTermsEnum}}
> wrapper when loading a {{{}TermsEnum{}}}, but that wrapper doesn't do
> anything to wrap postings or impacts. So timeouts will be enforced when
> moving to the "next" term, but not when iterating the postings/impacts
> associated with a term.
> I think we ought to wrap the postings/impacts as well with some form of
> timeout checking so timeouts can be enforced on long-running queries. I'm not
> sure why this wasn't done originally (back in 2014), but it was questioned
> back in 2020 on the original Jira SOLR-5986. Does anyone know of a good
> reason why we shouldn't enforce timeouts in this way?
> Related, we may also want to wrap things like {{seekExact}} and {{seekCeil}}
> given that only {{next}} is being wrapped currently.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
