kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r892189591
##########
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##########
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitSetIterator(bitSets[contextOrd], cost[contextOrd]);
}
+ public void setBitSet(BitSet bitSet, int cost) {
+ bitSets[ord] = bitSet;
Review Comment:
Thank you @jtibshirani @msokolov for your input!
I agree that we shouldn't modify core classes for tests, and we can create a
separate issue for possible collection optimizations
However I feel that this test is important as well, for deciding which query
would be suitable for pre-filtering (by comparing with post-filtering + over
selection time) and we should address this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
