[
https://issues.apache.org/jira/browse/LUCENE-10644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564642#comment-17564642
]
Yuting Gan commented on LUCENE-10644:
-------------------------------------
Thanks for discovering the issue with the current tests! I've updated the
failing unit tests in testBasic() and testBasicHierarchical() in
TestSortedSetDocValuesFacets with a new test schema
[#1013|https://github.com/apache/lucene/pull/1013]. I will really appreciate if
you can help me review the new testing method, and after it looks good to you,
I will change the all unit tests of getAllChildren. Thank you so much!
> Facets#getAllChildren testing should ignore child order
> -------------------------------------------------------
>
> Key: LUCENE-10644
> URL: https://issues.apache.org/jira/browse/LUCENE-10644
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Attachments: failing tests.png
>
>
> Our javadoc for {{Facets#getAllChildren}} explicitly calls out that callers
> should make no assumptions about child ordering, but a number of our own unit
> tests turn around and make that assumption. I ran into this when recently
> trying an optimization that would result in a different child ordering for
> {{{}getAllChildren{}}}, and found a number of unit tests that started
> failing. I'll upload a list of what I found failing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
