msokolov commented on PR #947:
URL: https://github.com/apache/lucene/pull/947#issuecomment-1181017377

   >  During merging when writing a merged vector field it looks like we first 
expand vector values only to again to compress them later? Would be nice to 
avoid this.
   
   In fact after checking, I don't think we are doing this expand/compress step 
*even though getVectorValues() returns `ExpandingVectorValues` to the merger*. 
This is because the merger uses the `binaryValue()` call to write the vectors 
themselves, and that value is unchanged by EVV, and the graph is created by the 
(now) polymorphic hnsw utils that also call `binaryValue()` when they are 
dealing with a field encoded as bytes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to