nknize commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1198316145
> We can commit this (once important feedback is addressed) and then PNP iterate. +1 I think this PR is ready and the remaining two items (multi geometry, and visitor pattern) can be added in follow on PRs. For multi geometry I opened [LUCENE-10666](https://issues.apache.org/jira/browse/LUCENE-10666) to discuss adding multi binary docvalues. I think this is the "logical" way to go for multi geometry docvalue support but can also see a technical argument for munging multi geometries into a single binary similar to `BinaryRangeDocValues`. I think we should discuss this and add multi support in a follow on improvement PR. > Maybe we could implement both Elastic's battle-tested (2 years in production) approach, and this new approach, and then over time cross-fertilize between the two? Unless iterating on this field is simply not preferred I'm not seeing the need for two fields since closing any gaps in follow on PRs (that's not already addressed above) would achieve the same result and avoid API confusion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
