shubhamvishu commented on PR #12183:
URL: https://github.com/apache/lucene/pull/12183#issuecomment-1456551815

   > On the other hand, queries discussed here have super cheap rewrites, e.g. 
FieldExistsQuery runs in O(num_segments) and doesn't perform any I/O so I don't 
think that its rewrite should be made concurrent?
   
   Yes, I'd drop `FieldExistsQuery` as it looks to be quite cheap. Among the 
other 2 queries, `BlendedTermQuery` seem to be good candidate to me to have a 
concurrent rewrite whereas `CompletionQuery` maybe not. Do you think we should 
go with making `BlendedTermQuery` ,`CompletionQuery` concurrent (or) maybe not 
? Let me know what do you think?
   
   > Indeed compound queries should not rewrite their sub queries via the 
executor, otherwise we could have threads in the executor joining other threads 
from the executor, which can lead to deadlocks.
   
   Yeah, thats answers why it was not working for compound ones. Thanks 
@jpountz !
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to