s1monw commented on PR #12711: URL: https://github.com/apache/lucene/pull/12711#issuecomment-1778962096
> Another question: do we have any testing around this sort-stability / block-preservation today? I'm getting nervous now that we are relying on an undocumented feature that just happens to work. EG I checked TestIndexSorting and it doesn't seem to call add/updateDocuments at all. I don't think we have any tests for this. Otherwise the build would have failed on this PR > The idea of more explicitly modeling doc-blocks makes sense to me, but I wonder if it would really enable "That way we can sort only on the parent document". What about the case (supported today) where we have nested blocks? I guess in that case we would have to figure out which parent docs are "top-level" and only sort by those? Wait, correct me if I am wrong but we don't support nested blocks with an API. You can model that with certain fields on the docs in the block but there is no API. The purpose of my suggestion was to make the root block a first class citizen. @mikemccand @martijnvg any opinions on this suggestion from above: https://github.com/apache/lucene/pull/12711#issuecomment-1776831638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
