mikemccand commented on code in PR #12295:
URL: https://github.com/apache/lucene/pull/12295#discussion_r1391341171
##########
lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/morfologik/MorphosyntacticTagsAttributeImpl.java:
##########
@@ -52,8 +52,8 @@ public void clear() {
@Override
public boolean equals(Object other) {
- if (other instanceof MorphosyntacticTagsAttribute) {
- return equal(this.getTags(), ((MorphosyntacticTagsAttribute)
other).getTags());
+ if (other instanceof MorphosyntacticTagsAttribute
morphosyntacticTagsAttribute) {
Review Comment:
I guess we keep this `equals` since it was already using `instanceof`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
