cpoerschke commented on code in PR #12674:
URL: https://github.com/apache/lucene/pull/12674#discussion_r1407992397
##########
lucene/analysis/opennlp/src/test/org/apache/lucene/analysis/opennlp/TestOpenNLPChunkerFilterFactory.java:
##########
@@ -58,7 +58,7 @@ public class TestOpenNLPChunkerFilterFactory extends
BaseTokenStreamTestCase {
8, 15, 17, 21, 23, 29, 30, 39, 46, 48, 49, 51, 57, 58
};
private static final String[] SENTENCES_chunks = {
- "B-NP", "I-NP", "I-NP", "B-VP", "B-NP", "I-NP", "O", "B-NP", "I-NP",
"I-NP", "O", "B-NP",
+ "B-NP", "I-NP", "I-NP", "I-NP", "I-NP", "I-NP", "O", "B-NP", "I-NP",
"I-NP", "O", "B-NP",
Review Comment:
> ... would seem more correct, no?
Upon further consideration, the _"Tagging models are created from tiny test
data in opennlp/tools/test-model-data/ and are not very accurate."_ comment
from line 31-32 above applies here probably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]