benwtrent commented on PR #13076: URL: https://github.com/apache/lucene/pull/13076#issuecomment-1930440518
> IMHO, the VectorSimilarity class should NOT be an ENUM and instead be an SPI with a symbolic name (using NamedSPILoader for the lookup) and the name should be stored in FieldInfo. I agree, enum doesn't make sense. SPI with a name lookup seems best to me. Here is my original issue that has since been closed. https://github.com/apache/lucene/issues/12219 One difficulty is making sure the SPI interface is one we want (seems `float[]` & `byte[]` is too restrictive?). Some other work from @ChrisHegarty (https://github.com/apache/lucene/pull/12703) shows that we may want to move away from `float[], float[]` and potentially an interface like. `score(int vectorOrdinal1, int vectorOrdinal2)` `score(float[] queryVector, int vectorOrdinal)` `score(byte[] queryVector, int vectorOrdinal)`. All that can be part of the separate discussions. Thanks @uschindler & @rmuir ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
