gsmiller commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1513502215
##########
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java:
##########
@@ -568,6 +568,12 @@ public Number getSpecificValue(String dim, String... path)
{
throw new UnsupportedOperationException();
}
+ @Override
+ public Number[] getBulkSpecificValues(FacetLabel[] facetLabels) {
+ // TODO: should we impl this?
Review Comment:
I am a bit curious around whether-or-not we should have a default
`getBulkSpecificValues` implementations in the `Facets` class that delegates to
`getSpecificValue`. We have this pattern in other places. Then again, looking
at all your implementations, they do something inherently different than just
delegating in this way, so maybe that's too trappy. What if we added to the
`Facets#getBulkSpecificValues` javadoc to mention that the results should be
identical to calling `getSpecificValue` repeatedly. That's probably enough of a
hint to someone implementing the `Facets` class on their own that they could
delegate in this way if they want? Personally, I think I'd be more in favor of
providing a default implementation that delegates along with javadoc hinting to
implementers that they should consider overriding it with a more performant
implementation, but I don't feel super strongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
