romseygeek commented on code in PR #13165: URL: https://github.com/apache/lucene/pull/13165#discussion_r1540259892
########## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ########## @@ -1130,7 +1137,7 @@ public boolean acceptField(String field) { @Override public void visitLeaf(Query query) { if (MultiTermHighlighting.canExtractAutomataFromLeafQuery(query) == false) { - if (!(query instanceof MatchAllDocsQuery || query instanceof MatchNoDocsQuery)) { + if (!UnifiedHighlighter.this.isIgnorableQuery(query)) { Review Comment: Can you add a test to TestUnifiedHighlighterExtensibility that checks that overrides to `isIgnorableQuery` work here as well? I think it will, but to be perfectly honest I can never remember the inheritance rules around class-specific `this` calls... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org