gf2121 commented on code in PR #13221:
URL: https://github.com/apache/lucene/pull/13221#discussion_r1544434866
##########
lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java:
##########
@@ -54,6 +54,11 @@ public Double value(int slot) {
return Double.valueOf(values[slot]);
}
+ @Override
+ protected long missingValueAsComparableLong() {
+ return NumericUtils.doubleToSortableLong(missingValue);
+ }
Review Comment:
Sorry for introducing unnecessary change in this PR!
> now we're also comparing values as longs.
Actually it is not 'adding long comparison' but 'moving bytes comparison to
long comparison'. For me this seems like a good simplification (and maybe
optimization as well? like https://github.com/apache/lucene/pull/12006).
Anyway, this change has nothing to do with the proposal of this PR, so I
proposed it separately in https://github.com/apache/lucene/pull/13246. If
https://github.com/apache/lucene/pull/13246 makes sense to you, we can work on
it first and then move forward with this PR. Otherwise I'll roll this PR back
to bytes stuff :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
