benwtrent commented on code in PR #13919:
URL: https://github.com/apache/lucene/pull/13919#discussion_r1803334241
##########
lucene/core/src/java/org/apache/lucene/util/quantization/ScalarQuantizer.java:
##########
@@ -568,29 +568,34 @@ private static List<ScoreDocsAndScoreVariance>
findNearestNeighbors(
* and `95`.
*
* @param arr array of floats
- * @param confidenceInterval the configured confidence interval
+ * @param confidenceIntervals the configured confidence intervals
* @return lower and upper quantile values
*/
- static float[] getUpperAndLowerQuantile(float[] arr, float
confidenceInterval) {
+ static float[][] getUpperAndLowerQuantiles(float[] arr, float[]
confidenceIntervals) {
Review Comment:
Intuitively, this would speed things up. But as you said in other comments,
the overall cost of quantization isn't really this part. But instead that we
iterate every vector and then quantize them. The calculating of the quantiles
or quantile candidates is a very small portion of the runtime :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
