mikemccand commented on code in PR #13910:
URL: https://github.com/apache/lucene/pull/13910#discussion_r1812937509
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java:
##########
@@ -260,7 +260,7 @@ public void search(String field, float[] target,
KnnCollector knnCollector, Bits
int node = results.topNode();
float minSimilarity = results.topScore();
results.pop();
- knnCollector.collect(node, minSimilarity);
+ knnCollector.collect(vectorValues.ordToDoc(node), minSimilarity);
Review Comment:
> Oh, that's a relief! I couldn't remember if we had that or not. At any
rate it is possible to create a sparse 90 index in tests now.
This is odd? When a Codec format is replaced, we move the "read only" part
to `backwards-codecs` module, and the full read/write original codec to
`test-framework` so that unit tests can produce a 9.0 index and run modern
tests (even new unit tests added since 9.0) against such "old" indices.
But that read/write codec format should not be able to produce an index that
the original 9.0 (core) format was not able to produce. They should be the
same original code ... so maybe sparse vector values were in fact writable in
9.0 (by accident?)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
