navneet1v commented on code in PR #14076:
URL: https://github.com/apache/lucene/pull/14076#discussion_r1889600647
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsFormat.java:
##########
@@ -78,21 +79,23 @@ public final class Lucene99FlatVectorsFormat extends
FlatVectorsFormat {
static final int DIRECT_MONOTONIC_BLOCK_SHIFT = 16;
private final FlatVectorsScorer vectorsScorer;
+ private final ReadAdvice readAdvice;
/** Constructs a format */
- public Lucene99FlatVectorsFormat(FlatVectorsScorer vectorsScorer) {
+ public Lucene99FlatVectorsFormat(FlatVectorsScorer vectorsScorer, ReadAdvice
readAdvice) {
Review Comment:
I like the idea of passing the read advice. If the top level format can
dictate the read advice then that makes code more better. +1 on this idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
