jainankitk commented on code in PR #14413:
URL: https://github.com/apache/lucene/pull/14413#discussion_r2032049110
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerTimer.java:
##########
@@ -33,9 +33,21 @@
* </pre>
*/
class QueryProfilerTimer {
-
private boolean doTiming;
- private long timing, count, lastCount, start;
+ private long timing, count, lastCount, start, earliestTimerStartTime;
Review Comment:
I feel it is still useful, as it is not necessary that all the threads start
execution immediately. Intuitively, if we submit 4 slices to executor service,
2 of them might be picked immediately on Thread A, B. Slice 3 starts on another
thread C (that was busy executing slice for different query), before thread A,
B finish slice 1,2 and thread A/B eventually pick slice 4. Please correct me if
I am missing something specific to concurrent implementation for Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
