rmuir commented on code in PR #14704:
URL: https://github.com/apache/lucene/pull/14704#discussion_r2104654751
##########
lucene/core/src/java/org/apache/lucene/search/similarities/BM25Similarity.java:
##########
@@ -217,6 +221,19 @@ private static class BM25Scorer extends SimScorer {
this.weight = boost * idf.getValue().floatValue();
}
+ private float score(float freq, float normInverse) {
Review Comment:
consider the name? it is too dangerous to have both these signatures, even
though float and long have different size:
```
float score(float, float);
float score(float, long);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
