rmuir commented on code in PR #14988:
URL: https://github.com/apache/lucene/pull/14988#discussion_r2226702333
##########
build-tools/build-infra/src/main/groovy/lucene.validation.source-patterns.gradle:
##########
@@ -97,9 +97,7 @@ class ValidateSourcePatternsTask extends DefaultTask {
@TaskAction
public void check() {
- def invalidPatterns = [
- (~$/\Q/**\E((?:\s)|(?:\*))*\Q{@inheritDoc}\E((?:\s)|(?:\*))*\Q*/\E/$) :
'{@inheritDoc} on its own is unnecessary',
- ]
+ def invalidPatterns = []
Review Comment:
Actually i'd remove `java` extension from line 34:
> List<String> extensions = ['java', 'xml',]
This should mean this task now only scans xml files. Thousands of less
files. The UTF-8 validation is already happening by `eclint` because
editorconfig says utf-8, so it validates that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
