jpountz commented on PR #14996:
URL: https://github.com/apache/lucene/pull/14996#issuecomment-3128130146
@msokolov @benwtrent You may want to take a look since vector search is
probably the most performance-critical code that is touched by this change due
to `AbstractKnnVectorQuery`, which passes the following implementing classes
for the `Bits` acceptDocs:
- `FixedBits` for unfiltered searches,
- `FixedBitSet` for dense filters,
- `SparseFixedBitSet` for sparse filters.
With this PR, dense filters and unfiltered searches both use a `FixedBits`
instance, so call sites of `Bits#get` within the vector search code become
bimorphic. I don't expect nightly benchmarks to see a difference though since
we don't run queries that are filtered by sparse filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
