navneet1v opened a new pull request, #15892:
URL: https://github.com/apache/lucene/pull/15892
### Description
Change access modifier for readAdvise in MMapDirectory. Made the access
modifier protected so that classes which overrides MMapDirectory can use the
readAdvise or if needed expose them.
I considered adding a getter for this parameter too, but went against it
since the return type is pretty weird. I am open to adding a getting too. If we
are happy with a getter like this:
```
public BiFunction<String, IOContext, Optional<ReadAdvice>> getReadAdvise() {
return readAdvice;
}
```
or we can also expose a function like
```
public ReadAdvice getReadAdviseForFile(String filename, IOContext ioContext)
{
return readAdvice.apply(filename, ioContext);
}
```
This will ensure that consumers can validate if readAdvise is correctly set
or not.
<!--
If this is your first contribution to Lucene, please make sure you have
reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
