michaeljmarshall commented on code in PR #16145: URL: https://github.com/apache/lucene/pull/16145#discussion_r3321025992
########## lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java: ########## Review Comment: This is actually wrong in a subtle way. A slice can pull in a subset of segments from the parent, then result in different `advice`, which ultimately modifies the internal advice, and can therefore lead to out of sync values for `isRandom`. As such, this extra metadata needs rethinking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
