Pulkitg64 commented on PR #15549: URL: https://github.com/apache/lucene/pull/15549#issuecomment-4606482063
In the new revision we centralized all fp16→fp32 conversion behind a single Float16AsFloatVectorValues class (merge/centroid) and a FieldWriter.floatVectorValue accessor (flush), so quantization always operates on fp32. This let us delete the duplicated QuantizedFloat16VectorValues/NormalizedFloat16VectorValues classes, the fp16 scalarQuantize(short[])/multiScalarQuantize(short[]) overloads (making OptimizedScalarQuantizer encoding-agnostic), and the redundant fp16 in-place normalizeVectors(), removing the duplicated fp16/fp32 branching flagged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
