msokolov commented on code in PR #15979:
URL: https://github.com/apache/lucene/pull/15979#discussion_r3659991448


##########
lucene/core/src/test/org/apache/lucene/codecs/lucene106/dedup/TestLucene106DedupHnswVectorsFormat.java:
##########
@@ -76,13 +99,84 @@ protected void assertOffHeapByteSize(LeafReader r, String 
fieldName) throws IOEx
     }
   }
 
-  /**
-   * This test indexes random vectors of small dimensions with high 
duplicates, checking that RAM
-   * usage is above a threshold. The RAM usage assumption breaks with the 
de-duplicating format.
-   */
+  /** Near copy of the original test, this one checks for size of 
<b>unique</b> vector count. */
   @Override
-  @Ignore
-  public void testWriterRamEstimate() {}
+  @SuppressWarnings("unchecked")
+  public void testWriterRamEstimate() throws IOException {

Review Comment:
   thanks for the nice test!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to