[
https://issues.apache.org/jira/browse/MADLIB-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323373#comment-16323373
]
ASF GitHub Bot commented on MADLIB-1197:
----------------------------------------
GitHub user orhankislal opened a pull request:
https://github.com/apache/madlib/pull/224
1.13 Upgrade and MLP IC fix
JIRA: MADLIB-1197
Additional Author: Nandish Jayaram <[email protected]>
- 1.13 Upgrade does not drop the kNN help functions even though their
return types are changed. This commit adds the missing functions to the
changelist and alters the upgrade_util.py_in so that functions without
arguments can be dropped.
- Some assert thresholds are too strict for MLP in IC. This commit relaxes
those thresholds.
Closes #224
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orhankislal/madlib bugfix/mlp_and_upgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit 0fdf136b4e0ad0fd2c54bab2144045b11ba5884b
Author: Orhan Kislal <okislal@...>
Date: 2018-01-12T01:22:30Z
1.13 Upgrade and MLP IC fix
JIRA: MADLIB-1197
Additional Author: Nandish Jayaram <[email protected]>
- 1.13 Upgrade does not drop the kNN help functions even though their
return types are changed. This commit adds the missing functions to the
changelist and alters the upgrade_util.py_in so that functions without
arguments can be dropped.
- Some assert thresholds are too strict for MLP in IC. This commit relaxes
those thresholds.
Closes #224
----
> Upgrade fails for 1.13
> ----------------------
>
> Key: MADLIB-1197
> URL: https://issues.apache.org/jira/browse/MADLIB-1197
> Project: Apache MADlib
> Issue Type: Bug
> Components: Upgrade
> Reporter: Orhan Kislal
> Fix For: v1.14
>
>
> Upgrading to 1.13 fails with the following error:
> {code}
> madpack.py: INFO : > - knn
> madpack.py: ERROR : TEST CASE RESULTed executing
> /tmp/madlib.xOnniK/knn/knn.sql_in.tmp
> madpack.py: ERROR : Check the log at /tmp/madlib.xOnniK/knn/knn.sql_in.log
> Exception:
> (<type 'exceptions.Exception'>, Exception(), <traceback object at 0x12cb368>)
> File
> "/usr/local/greenplum-db-4.3.14.0/madlib/Versions/1.13/bin/../madpack/madpack.py",
> line 1171, in main
> _db_upgrade(schema, dbrev)
> File
> "/usr/local/greenplum-db-4.3.14.0/madlib/Versions/1.13/bin/../madpack/madpack.py",
> line 571, in _db_upgrade
> _db_create_objects(schema, None, True, sc)
> File
> "/usr/local/greenplum-db-4.3.14.0/madlib/Versions/1.13/bin/../madpack/madpack.py",
> line 734, in _db_create_objects
> raise Exception
> madpack.py: ERROR : MADlib upgrade failed.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
