[ 
https://issues.apache.org/jira/browse/MADLIB-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372290#comment-16372290
 ] 

ASF GitHub Bot commented on MADLIB-1207:
----------------------------------------

GitHub user njayaram2 opened a pull request:

    https://github.com/apache/madlib/pull/237

    Bugfix: MLP predict using 1.12 model fails on later versions

    JIRA: MADLIB-1207
    
    MADlib 1.12 did not support grouping in MLP. The summary table created
    used to have the mean and std used for standardizing the independent
    variable. From MADlib 1.13 onwards, grouping was supported, and the mean
    and std were moved to the standardization table.
    This resulted in a failure when MADlib 1.12 MLP models were used to
    predict using MADlib 1.13. This commit fixes this issue.
    
    Closes #237

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/njayaram2/madlib bug/mlp-1.12model-grouping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit 63daad10bf8c610d60be738f79e9bdc22ddc6483
Author: Nandish Jayaram <njayaram@...>
Date:   2018-02-22T01:18:57Z

    Bugfix: MLP predict using 1.12 model fails on later versions
    
    JIRA: MADLIB-1207
    
    MADlib 1.12 did not support grouping in MLP. The summary table created
    used to have the mean and std used for standardizing the independent
    variable. From MADlib 1.13 onwards, grouping was supported, and the mean
    and std were moved to the standardization table.
    This resulted in a failure when MADlib 1.12 MLP models were used to
    predict using MADlib 1.13. This commit fixes this issue.
    
    Closes #237

----


> Neural net models trained in 1.12 don’t predict in 1.13
> -------------------------------------------------------
>
>                 Key: MADLIB-1207
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1207
>             Project: Apache MADlib
>          Issue Type: Bug
>          Components: Module: Neural Networks
>            Reporter: Frank McQuillan
>            Priority: Minor
>             Fix For: v1.14
>
>
> This is a bug related to when we added grouping support in 1.13 and did not 
> properly account for it in the predict function. 
> The grouping column should be optional in the predict function to support 
> 1.12 models.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to