[ https://issues.apache.org/jira/browse/MADLIB-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581752#comment-16581752 ]
Frank McQuillan commented on MADLIB-1060: ----------------------------------------- I think so. The expressions must return a valid type for the parameters, which is {code} point_source TEXT. Name of the table containing the training data points. Training data points are expected to be stored row-wise in a column of type DOUBLE PRECISION[]. point_column_name TEXT. Name of the column with training data points. {code} and {code} test_source TEXT. Name of the table containing the test data points. Testing data points are expected to be stored row-wise in a column of type DOUBLE PRECISION[]. test_column_name TEXT. Name of the column with testing data points. {code} > Support expressions for column names in k-NN > -------------------------------------------- > > Key: MADLIB-1060 > URL: https://issues.apache.org/jira/browse/MADLIB-1060 > Project: Apache MADlib > Issue Type: Improvement > Components: k-NN > Reporter: Frank McQuillan > Assignee: Himanshu Pandey > Priority: Minor > Labels: starter > Fix For: v2.0 > > > Follow on to > https://issues.apache.org/jira/browse/MADLIB-927 > {code} > knn( point_source, > point_column_name, > label_column_name, > test_source, > test_column_name, > id_column_name, > output_table, > operation, > k > ) > {code} > Possible improvements: > 1) The parameters 'point_column_name' and 'test_column_name' should support > regular PostgreSQL expressions. > 2) Should we infer 'c' or 'r' from the data types, rather than have to say > explicitly? -- This message was sent by Atlassian JIRA (v7.6.3#76005)