[ 
https://issues.apache.org/jira/browse/MADLIB-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634668#comment-16634668
 ] 

ASF GitHub Bot commented on MADLIB-1278:
----------------------------------------

GitHub user njayaram2 opened a pull request:

    https://github.com/apache/madlib/pull/327

    Upgrade: Fix issue with upgrading RPM to 1.15.1

    JIRA: MADLIB-1278
    
    During RPM upgrade, rpm_post.sh is run first, followed by
    rpm_post_uninstall.sh. So we must do all the uninstallation specific
    stuff based on the current operation being uninstall or upgrade.
    This commit makes the necessary change to remove symlinks only during
    uninstallation, and not while upgrading.
    
    Co-authored-by: Domino Valdano <[email protected]>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib rpm-upgrade-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #327
    
----
commit 8234449be7d8522aa6d351bf504a573558cad4d3
Author: Nandish Jayaram <njayaram@...>
Date:   2018-10-01T21:32:44Z

    Upgrade: Fix issue with upgrading RPM to 1.15.1
    
    JIRA: MADLIB-1278
    
    During RPM upgrade, rpm_post.sh is run first, followed by
    rpm_post_uninstall.sh. So we must do all the uninstallation specific
    stuff based on the current operation being uninstall or upgrade.
    This commit makes the necessary change to remove symlinks only during
    uninstallation, and not while upgrading.
    
    Co-authored-by: Domino Valdano <[email protected]>

----


> RPM: Upgrade does not work from 1.15 to 1.15.1
> ----------------------------------------------
>
>                 Key: MADLIB-1278
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1278
>             Project: Apache MADlib
>          Issue Type: Bug
>          Components: Build System
>            Reporter: Orhan Kislal
>            Priority: Major
>             Fix For: v1.15.1
>
>
> It seems there is an issue with upgrading the 1.15 version of MADlib rpm. The 
> RPM upgrade process works as follows:
> {code}
> Run the %pre section of the RPM being installed.
> Install the files that the RPM provides.
> Run the %post section of the RPM.
> Run the %preun of the old package.
> Delete any old files not overwritten by the newer version. ...
> Run the %postun hook of the old package.
> {code}
> In version 1.15, we added a post-uninstall script that removed the links for 
> Current, bin and doc folders (also cleaned the Versions folder if empty). 
> While this makes sense for uninstallation, upgrade process runs this script 
> at the end and removes the newly updated links. 
> We should provide a script to recreate these links with the release of 1.15.1 
> and any other release that supports upgrading from 1.15.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to