[
https://issues.apache.org/jira/browse/MADLIB-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694384#comment-16694384
]
Orhan Kislal edited comment on MADLIB-1283 at 11/21/18 8:29 AM:
----------------------------------------------------------------
There are a few fixes required for PG11 support (in addition to the build
related changes).
TRUE and FALSE are not defined by Postgresql anymore, we will change them to
true and false.
We have to use TupleDescAttr(tupdesc, inID) instead of accessing this field
directly (tupdesc->attrs[inID])
In addition, we need to change how we access pg_proc table.
In PG11, proisagg and proiswindow columns of pg_proc are combined into a single
column: prokind. This column is used in two specific places:
knn: easy to add a simple pg version check since the code is called from python.
kmeans: messy, since the code is SQL (plpgsql) and we have to parse the version
string. We might want to move the kmeans code to python as well.
Finally, we use this column in the create_changelist.py scripts. When we drop
the support for PG10, we should update them as well.
was (Author: okislal):
There are a few fixes required for PG11 support (in . addition to the build
related changes).
TRUE and FALSE are not defined by Postgresql anymore, we will change them to
true and false.
We have to use TupleDescAttr(tupdesc, inID) instead of accessing this field
directly (tupdesc->attrs[inID])
In addition, we need to change how we access pg_proc table.
In PG11, proisagg and proiswindow columns of pg_proc are combined into a single
column: prokind. This column is used in two specific places:
knn: easy to add a simple pg version check since the code is called from python.
kmeans: messy, since the code is SQL (plpgsql) and we have to parse the version
string. We might want to move the kmeans code to python as well.
Finally, we use this column in the create_changelist.py scripts. When we drop
the support for PG10, we should update them as well.
> Postgres 11 support
> -------------------
>
> Key: MADLIB-1283
> URL: https://issues.apache.org/jira/browse/MADLIB-1283
> Project: Apache MADlib
> Issue Type: Improvement
> Components: Build System
> Reporter: Darafei Praliaskouski
> Assignee: Orhan Kislal
> Priority: Major
> Fix For: v1.16
>
>
> Postgres 11.1 just got released. MADlib doesn't support it yet.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
