[ 
https://issues.apache.org/jira/browse/MAHOUT-743?focusedWorklogId=1000657&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1000657
 ]

ASF GitHub Bot logged work on MAHOUT-743:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/26 16:05
            Start Date: 17/Jan/26 16:05
    Worklog Time Spent: 10m 
      Work Description: Rutuja123-dos commented on PR #844:
URL: https://github.com/apache/mahout/pull/844#issuecomment-3764060226

   Thanks for the feedback @ryankert01. You’re right, I see now that this test 
is just checking NumPy and not the actual project logic.
   I’m going to look back at the source code to find the exact function that’s 
causing the out-of-bounds issue. I'll rewrite the test to call that function 
instead and update my PR. Thanks for pointing that out




Issue Time Tracking
-------------------

    Worklog Id:     (was: 1000657)
    Time Spent: 1.5h  (was: 1h 20m)

> Allow use of random seeds during unit tests
> -------------------------------------------
>
>                 Key: MAHOUT-743
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-743
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Assignee: Sean R. Owen
>            Priority: Major
>             Fix For: 0.6
>
>         Attachments: MAHOUT-743.patch, RandomWrapper.patch
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The RandomUtils package has a trick for running unit tests repeatably. All 
> random generators created with RandomUtils.getRandom() are started with seed 
> 0. Unfortunately, all random generators started with 
> RandomUtils.getRandom(seed) effectively run from a seed of 0. Thus, code 
> which deliberately creates Random objects with seeds does not work correctly 
> under unit tests.
> The problem is that the logic in RandomWrapper tests for unit test mode and 
> settable seed mode in the wrong order.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to