[
https://issues.apache.org/jira/browse/MARVIN-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846902#comment-16846902
]
Daniel martins Takabayashi commented on MARVIN-1:
-------------------------------------------------
Hi Huys, sorry to give my comments so late but....
Reviwing this [PR|[https://github.com/apache/incubator-marvin/pull/21]]
I think we should avoid to change the existent structure righ now, changing the
engine-executor to engine-server and this is why I think this:
* Internal link, names and scripts must be refactored and this means more
enforts to test and garanty that everything is working
* External link, as articles, manuals, citations, repositories (pip, maven)
should be changed also otherwise we going to create a bunch of broke links
* package names should be change to follow good practices
We need to think what our the gains of change the sub project name. Til now my
perspective is, dosen't worth it.
Personally I dont believe we need to do this. I think to be a little safer we
just should create the new staffs and just refactor the minimum to avoid big
eforts and big reviews.
Lets disscuss about it?
> Implement Dockerfile to generate Marvin-App docker image (R based)
> ------------------------------------------------------------------
>
> Key: MARVIN-1
> URL: https://issues.apache.org/jira/browse/MARVIN-1
> Project: Apache Marvin
> Issue Type: New Feature
> Reporter: Lucas Bonatto Miguel
> Assignee: Lucas Bonatto Miguel
> Priority: Major
> Fix For: 0.0.5
>
>
> The generated docker image should have:
> - A binary version of the engine-executor
> - A version of the R-common-lib
> - The user's engine code
> Additional verification:
> - Make sure it is possible to build the image from Marvin CLI
> - Once the image is built, make sure you can interact with the container via
> docker-sdk
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
