[
https://issues.apache.org/jira/browse/MARVIN-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936526#comment-16936526
]
Harshit commented on MARVIN-43:
-------------------------------
Hello there,
I would like to work on this. Let me know if you are looking for contributions.
Ran the coverage for engine and python toolbox, (without diving deep into the
project)
Couple of things:
* Engine Coverage is at 58.92% currently. Attached the screenshot for
scoverage: !Screen Shot 2019-09-24 at 12.47.05 AM.png|width=350,height=366!
* Python test runner requires spark to be installed on the box , else throws
an error:
!image-2019-09-24-00-52-55-778.png|width=593,height=101!
Fixing this particular issue will require lowering the threshold in the
codecov.yml. Either we can work on increasing the coverage of the engine to 70%
and then picking up this issue or lowering the threshold and then picking this
up. I am unsure about how incubator projects work generally. Looking for
suggestions.
> Codecov Setting for Multi Language
> ----------------------------------
>
> Key: MARVIN-43
> URL: https://issues.apache.org/jira/browse/MARVIN-43
> Project: Apache Marvin
> Issue Type: Bug
> Reporter: Wei Chen
> Priority: Major
> Labels: CI
> Fix For: 0.0.5
>
> Attachments: Screen Shot 2019-09-24 at 12.47.05 AM.png, Screen Shot
> 2019-09-24 at 12.48.50 AM.png, Screen Shot 2019-09-24 at 12.51.45 AM.png,
> image-2019-09-24-00-52-55-778.png
>
>
> Currently, in our codecov, we can only see the coverage of our python toolbox.
> https://codecov.io/gh/apache/incubator-marvin
> The engine is missing.
> Based on codecov's document, it shouldn't be a problem for us to have 2
> languages submitting reports to codecov since it should simply add them up.
> However, this is not happening right now.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
