[ 
https://issues.apache.org/jira/browse/SCM-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jakub Bochenski updated SCM-798:
--------------------------------
    Description: 
{code}[DEBUG] Configuring mojo 
'org.apache.maven.plugins:maven-scm-plugin:1.9.4:branch' with basic 
configurator -->
[DEBUG]   (f) basedir = /home/acme/gotham/common_ui
[DEBUG]   (f) branch = 2.2/2.2.0
[DEBUG]   (f) connectionType = connection
[DEBUG]   (s) connectionUrl = 
scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
[DEBUG]   (f) developerConnectionUrl = 
scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
[DEBUG]   (f) pushChanges = true
[DEBUG]   (f) remoteBranching = false
[DEBUG]   (f) settings = org.apache.maven.execution.SettingsAdapter@7b300cde
[DEBUG] -- end configuration --
[INFO] Final Branch Name: '2.2/2.2.0'
[INFO] Executing: /bin/sh -c cd /home/acme/gotham/common_ui && svn 
--non-interactive copy --file /tmp/maven-scm-1267210601.commit . 
svn+ssh://s...@svn.acme.com/repos/branches/2.2/2.2.0
{code}

I can see this code handling {{tagBase}}, but there is none for {{branchBase}}
{code}
            if ( !StringUtils.isEmpty( tagBase ) && 
repository.getProvider().equals( "svn" ) )
            {
                SvnScmProviderRepository svnRepo = (SvnScmProviderRepository) 
repository.getProviderRepository();
                svnRepo.setTagBase( tagBase );
            }{code}
Adding a parallel handling for {{branchBase}} param should be trivial. 

Correcting the documentation is another thing -- the {{tagBase}} parameter is 
present on the base Mojo class even though it's ignored in some goals.

  was:
{code}[DEBUG] Configuring mojo 
'org.apache.maven.plugins:maven-scm-plugin:1.9.4:branch' with basic 
configurator -->
[DEBUG]   (f) basedir = /home/acme/gotham/common_ui
[DEBUG]   (f) branch = 2.2/2.2.0
[DEBUG]   (f) connectionType = connection
[DEBUG]   (s) connectionUrl = 
scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
[DEBUG]   (f) developerConnectionUrl = 
scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
[DEBUG]   (f) pushChanges = true
[DEBUG]   (f) remoteBranching = false
[DEBUG]   (f) settings = org.apache.maven.execution.SettingsAdapter@7b300cde
[DEBUG] -- end configuration --
[INFO] Final Branch Name: '2.2/2.2.0'
[INFO] Executing: /bin/sh -c cd /home/acme/gotham/common_ui && svn 
--non-interactive copy --file /tmp/maven-scm-1267210601.commit . 
svn+ssh://s...@svn.acme.com/repos/branches/2.2/2.2.0
{code}

I can see this code handling {{tagBase}}, but there is none for {{branchBase}}
{code}
            if ( !StringUtils.isEmpty( tagBase ) && 
repository.getProvider().equals( "svn" ) )
            {
                SvnScmProviderRepository svnRepo = (SvnScmProviderRepository) 
repository.getProviderRepository();
                svnRepo.setTagBase( tagBase );
            }{code}
Adding a parallel handling for {branchBase}} param should be trivial. 

Correcting the documentation is another thing -- the {{tagBase}} parameter is 
present on the base Mojo class even though it's ignored in some goals.


> scm:branch ignores the tagBase parameter, there is not branchBase parameter
> ---------------------------------------------------------------------------
>
>                 Key: SCM-798
>                 URL: https://issues.apache.org/jira/browse/SCM-798
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-plugin, maven-scm-provider-svn
>    Affects Versions: 1.9.4
>            Reporter: Jakub Bochenski
>            Priority: Blocker
>
> {code}[DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-scm-plugin:1.9.4:branch' with basic 
> configurator -->
> [DEBUG]   (f) basedir = /home/acme/gotham/common_ui
> [DEBUG]   (f) branch = 2.2/2.2.0
> [DEBUG]   (f) connectionType = connection
> [DEBUG]   (s) connectionUrl = 
> scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
> [DEBUG]   (f) developerConnectionUrl = 
> scm:svn:svn+ssh://s...@svn.acme.com/repos/trunk/common_ui
> [DEBUG]   (f) pushChanges = true
> [DEBUG]   (f) remoteBranching = false
> [DEBUG]   (f) settings = org.apache.maven.execution.SettingsAdapter@7b300cde
> [DEBUG] -- end configuration --
> [INFO] Final Branch Name: '2.2/2.2.0'
> [INFO] Executing: /bin/sh -c cd /home/acme/gotham/common_ui && svn 
> --non-interactive copy --file /tmp/maven-scm-1267210601.commit . 
> svn+ssh://s...@svn.acme.com/repos/branches/2.2/2.2.0
> {code}
> I can see this code handling {{tagBase}}, but there is none for {{branchBase}}
> {code}
>             if ( !StringUtils.isEmpty( tagBase ) && 
> repository.getProvider().equals( "svn" ) )
>             {
>                 SvnScmProviderRepository svnRepo = (SvnScmProviderRepository) 
> repository.getProviderRepository();
>                 svnRepo.setTagBase( tagBase );
>             }{code}
> Adding a parallel handling for {{branchBase}} param should be trivial. 
> Correcting the documentation is another thing -- the {{tagBase}} parameter is 
> present on the base Mojo class even though it's ignored in some goals.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to